handreyrc commented on code in PR #2164:
URL:
https://github.com/apache/incubator-kie-tools/pull/2164#discussion_r1536298079
##########
packages/editor/src/envelope/KeyBindingsHelpOverlay/KeyBindingsHelpOverlay.tsx:
##########
@@ -82,11 +84,13 @@ export function KeyBindingsHelpOverlay() {
}
}, [showing]);
+ const themeCss = envelopeContext.supportedThemes.length > 1 && !theme! &&
theme === EditorTheme.DARK ? " dark" : "";
Review Comment:
@caponetto;
Sure, it makes sense, I moved this logic into a function and I'm also
testing if the theme is among the supported themes this way we dont need to
test if we support more than one theme anymore.
The "!theme!" thing is fixed. It was sort of a java (not !) lapse. it is
fixed as well.
The two issues you reported above are fixed as well.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
