yurloc commented on code in PR #5812:
URL:
https://github.com/apache/incubator-kie-drools/pull/5812#discussion_r1546760980
##########
drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRL6Expressions.g4:
##########
@@ -908,11 +925,13 @@ in_key
;
operator_key
- // At the moment, we list possible DRLLexer tokens here, but we may be able
to improve this by isolating lexers. IDENTIFIER is required to accept custom
operators
- // We need to keep this semantic predicate for custom operators
- : {(helper.isPluggableEvaluator(false))}?
id=(IDENTIFIER|DRL_MATCHES|DRL_MEMBEROF|DRL_CONTAINS|DRL_EXCLUDES|DRL_SOUNDSLIKE|DRL_STR)
{ helper.emit($id, DroolsEditorType.KEYWORD); }
+ // IDENTIFIER is required to accept custom operators. We need to keep this
semantic predicate for custom operators
+ : {(helper.isPluggableEvaluator(false))}? id=IDENTIFIER {
helper.emit($id, DroolsEditorType.KEYWORD); }
+ // At the moment, we list possible DRLLexer tokens here, but we may be able
to improve this by isolating lexers.
Review Comment:
@tkobayas This comment may need improving. We no longer list the keywords
here but in the `builtInOperator` rule. Plus, I don't know what's meant by
isolating lexers and how that can help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
