yurloc commented on code in PR #5812:
URL:
https://github.com/apache/incubator-kie-drools/pull/5812#discussion_r1546773602
##########
drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRLParser.g4:
##########
@@ -161,13 +161,7 @@ relationalOperator
| temporalOperator
;
-drlRelationalOperator
- : DRL_NOT? DRL_MATCHES
- | DRL_NOT? DRL_MEMBEROF
- | DRL_NOT? DRL_CONTAINS
- | DRL_NOT? DRL_EXCLUDES
- | DRL_NOT? DRL_SOUNDSLIKE
- | DRL_NOT? DRL_STR LBRACK IDENTIFIER RBRACK ;
+drlRelationalOperator : DRL_NOT? builtInOperator ;
Review Comment:
Not 100% accurate as some operators do not support negation (`==`, `!=`,
`<`, etc.) but I believe we can afford this inaccuracy at this point in the
DRLParser, which is more high-level and not primarily focused on expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
