yurloc commented on code in PR #5812: URL: https://github.com/apache/incubator-kie-drools/pull/5812#discussion_r1546765479
########## drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRLParser.g4: ########## @@ -142,7 +142,7 @@ inExpression : left=relationalExpression ( 'not'? 'in' LPAREN drlExpression (COM relationalExpression : left=drlExpression (right=orRestriction)* ; orRestriction : left=andRestriction (OR right=andRestriction)* ; andRestriction : left=singleRestriction (AND right=singleRestriction)* ; -singleRestriction : op=relationalOperator drlExpression ; +singleRestriction : op=relationalOperator squareArguments? drlExpression ; Review Comment: Needed for some operators that take arguments, for example, `str`, `after`, and `before`. This may not be 100% accurate as not all operators take operators but it's completely in line with the expression parser. ########## drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRLParser.g4: ########## @@ -142,7 +142,7 @@ inExpression : left=relationalExpression ( 'not'? 'in' LPAREN drlExpression (COM relationalExpression : left=drlExpression (right=orRestriction)* ; orRestriction : left=andRestriction (OR right=andRestriction)* ; andRestriction : left=singleRestriction (AND right=singleRestriction)* ; -singleRestriction : op=relationalOperator drlExpression ; +singleRestriction : op=relationalOperator squareArguments? drlExpression ; Review Comment: Needed for some operators that take arguments, for example, `str`, `after`, and `before`. This may not be 100% accurate as not all operators take arguments but it's completely in line with the expression parser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
