fjtirado commented on code in PR #3477:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3477#discussion_r1574497428
##########
quarkus/addons/messaging/common/src/main/java/org/kie/kogito/addon/quarkus/messaging/common/QuarkusTopicDiscovery.java:
##########
@@ -68,7 +68,15 @@ private String extractChannelName(String property, String
prefix) {
if (channelName.contains(".")) {
channelName = channelName.substring(0, channelName.indexOf("."));
}
- final Optional<String> topicName =
ConfigProvider.getConfig().getOptionalValue(prefix + channelName +
TOPIC_SUFFIX, String.class);
+ final Optional<String> topicName = getOptionalValue(prefix +
channelName + TOPIC_SUFFIX);
return topicName.orElse(channelName);
}
+
+ Iterable<String> getPropertyNames() {
Review Comment:
Sorry, I forgot to mention why ;).
It is just styling. I prefer to use package for methods that might be called
only within the package and protected for methods that might be inherited.
It is true that package is more restrictive (a protected can be inherited
outside the original package) and you are only overriding from the unit test
within the same package, theferore both are fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
