porcelli commented on code in PR #3477:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3477#discussion_r1574766483
##########
quarkus/addons/messaging/common/src/test/java/org/kie/kogito/addon/quarkus/messaging/common/QuarkusTopicDiscoveryTest.java:
##########
@@ -83,21 +75,49 @@ void verifyTopicsWithNoPropertiesSet() {
eventsMeta.add(new CloudEventMeta("event1", "", EventKind.CONSUMED));
eventsMeta.add(new CloudEventMeta("event2", "", EventKind.PRODUCED));
- final TopicDiscovery discovery = new QuarkusTopicDiscovery();
+ final TopicDiscovery discovery = new QuarkusTopicDiscovery() {
+ Iterable<String> getPropertyNames() {
+ return new HashSet<>();
+ }
+
+ Optional<String> getOptionalValue(String key) {
+ return Optional.empty();
+ }
+ };
final List<Topic> topics = discovery.getTopics(eventsMeta);
assertThat(topics).hasSize(2);
expectedTopics.forEach(e -> assertThat(topics.stream().anyMatch(t ->
t.getName().equals(e.getName()) && t.getType() == e.getType())).isTrue());
}
@Test
- @ClearSystemProperty(key =
"mp.messaging.outgoing.processedtravellers.connector")
- @ClearSystemProperty(key = "mp.messaging.outgoing.processedtravellers.url")
- @ClearSystemProperty(key =
"mp.messaging.outgoing.processedtravellers.topic")
- @ClearSystemProperty(key =
"mp.messaging.incoming.kogito_incoming_stream.connector")
- @ClearSystemProperty(key =
"mp.messaging.incoming.kogito_incoming_stream.topic")
void verifyTopicsWithPropertiesAndChannels() {
- final TopicDiscovery discovery = new QuarkusTopicDiscovery();
+ final TopicDiscovery discovery = new QuarkusTopicDiscovery() {
+ Iterable<String> getPropertyNames() {
+ return new HashSet<>();
+ }
+
+ Optional<String> getOptionalValue(String key) {
+ return Optional.empty();
+ }
+ };
final List<Topic> topics =
discovery.getTopics(Collections.emptyList());
assertThat(topics).isEmpty();
}
+
+ private TopicDiscovery getTopicDiscovery(Map.Entry<String, String>...
entries) {
+ return new QuarkusTopicDiscovery() {
+ final Map<String, String> properties = Map.ofEntries(entries);
+
+ @Override
+ Iterable<String> getPropertyNames() {
+ return properties.keySet();
+ }
+
+ @Override
+ Optional<String> getOptionalValue(String key) {
+ return Optional.ofNullable(properties.get(key));
+ }
+ };
+ }
+
Review Comment:
@fjtirado improved test code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
