porcelli commented on code in PR #3477:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3477#discussion_r1574707460
##########
quarkus/addons/messaging/common/src/main/java/org/kie/kogito/addon/quarkus/messaging/common/QuarkusTopicDiscovery.java:
##########
@@ -68,7 +68,15 @@ private String extractChannelName(String property, String
prefix) {
if (channelName.contains(".")) {
channelName = channelName.substring(0, channelName.indexOf("."));
}
- final Optional<String> topicName =
ConfigProvider.getConfig().getOptionalValue(prefix + channelName +
TOPIC_SUFFIX, String.class);
+ final Optional<String> topicName = getOptionalValue(prefix +
channelName + TOPIC_SUFFIX);
return topicName.orElse(channelName);
}
+
+ Iterable<String> getPropertyNames() {
Review Comment:
as this is in the personal preference realm, I'll leave as is as my personal
preference is default scope as it's more restrictive and supposed to be used
only by unit test to avoid using environment config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
