porcelli commented on code in PR #3525:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1608590390
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deployment/deployment-no-service.yaml:
##########
@@ -36,7 +36,7 @@ spec:
spec:
containers:
- name: example-deployment-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
isn't this a dead code? the quay.io/kiegroup/process-quarkus-example:latest
is years old (with tons of security issues btw).
we don't build such image anywhere that I could find, or am I missing
something?
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deployment/pod-deployment-no-service.yaml:
##########
@@ -57,7 +57,7 @@ spec:
defaultMode: 420
containers:
- name: example-deployment-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
same question
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deploymentConfig/deployment-config-no-service.yaml:
##########
@@ -34,7 +34,7 @@ spec:
spec:
containers:
- name: example-dc-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
same
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deploymentConfig/pod-deployment-config-no-service.yaml:
##########
@@ -81,7 +81,7 @@ spec:
readOnly: true
mountPath: /var/run/secrets/kubernetes.io/serviceaccount
terminationMessagePolicy: File
- image: 'quay.io/kiegroup/process-quarkus-example:latest'
+ image: 'docker.io/apache/incubator-kie-process-quarkus-example:latest'
Review Comment:
and here
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deploymentConfig/pod-deployment-config-no-service.yaml:
##########
@@ -149,5 +149,5 @@ status:
state:
running:
startedAt: '2022-08-22T17:30:29Z'
- image: 'quay.io/kiegroup/process-quarkus-example:latest'
+ image: 'docker.io/apache/incubator-kie-process-quarkus-example:latest'
Review Comment:
here we go again :)
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deployment/pod-deployment-no-service.yaml:
##########
@@ -121,6 +121,6 @@ status:
lastState: {}
ready: true
restartCount: 0
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
same
##########
quarkus/addons/tracing-decision/deployment/src/main/resources/application.properties:
##########
@@ -17,4 +17,4 @@
# under the License.
#
-quarkus.kogito.dev-services-trusty.image-name=quay.io/kiegroup/kogito-trusty-postgresql:${version.org.kie.kogito.trusty-service-postgresql}
+quarkus.kogito.dev-services-trusty.image-name=docker.io/apache/incubator-kie-kogito-trusty-postgresql:${version.org.kie.kogito.trusty-service-postgresql}
Review Comment:
where this image is published?
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/pod/pod-no-service.yaml:
##########
@@ -64,5 +64,5 @@ status:
lastState: {}
ready: true
restartCount: 0
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deployment/deployment.yaml:
##########
@@ -35,7 +35,7 @@ spec:
spec:
containers:
- name: example-deployment-with-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
same question
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deployment/replica-set-deployment-no-service.yaml:
##########
@@ -46,7 +46,7 @@ spec:
spec:
containers:
- name: example-deployment-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
same
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/statefulset/statefulset-pod-no-service.yaml:
##########
@@ -126,6 +126,6 @@ status:
lastState: {}
ready: true
restartCount: 0
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/tracing-decision/integration-tests/src/test/resources/application.properties:
##########
@@ -31,6 +31,6 @@
mp.messaging.outgoing.kogito-tracing-model.topic=kogito-tracing-model
mp.messaging.outgoing.kogito-tracing-model.value.serializer=org.apache.kafka.common.serialization.StringSerializer
mp.messaging.outgoing.kogito-tracing-model.auto.offset.reset=earliest
-quarkus.kogito.dev-services-trusty.image-name=quay.io/kiegroup/kogito-trusty-postgresql:latest
+quarkus.kogito.dev-services-trusty.image-name=docker.io/apache/incubator-kie-kogito-trusty-postgresql:latest
Review Comment:
can't find this image source; mind help locate it?
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/statefulset/statefulset-pod-no-service.yaml:
##########
@@ -59,7 +59,7 @@ spec:
defaultMode: 420
containers:
- name: example-statefulset-without-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deploymentConfig/deployment-config.yaml:
##########
@@ -34,7 +34,7 @@ spec:
spec:
containers:
- name: example-dc-with-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
here too
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/pod/pod-no-service.yaml:
##########
@@ -26,7 +26,7 @@ metadata:
spec:
containers:
- name: process-quarkus-example-pod-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/pod/pod-no-service-custom-port-name.yaml:
##########
@@ -26,7 +26,7 @@ metadata:
spec:
containers:
- name: pod-no-service-custom-port
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/statefulset/statefulset.yaml:
##########
@@ -36,7 +36,7 @@ spec:
spec:
containers:
- name: example-statefulset-with-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deploymentConfig/replication-controller-dc-no-svc.yaml:
##########
@@ -26,7 +26,7 @@ metadata:
openshift.io/deployment.status-reason: config change
openshift.io/deployment.replicas: '1'
openshift.io/encoded-deployment-config: >
-
{"kind":"DeploymentConfig","apiVersion":"apps.openshift.io/v1","metadata":{"name":"example-dc-no-service","namespace":"serverless-workflow-greeting-quarkus","uid":"a01d76e9-6b3a-48bf-8224-acb9de3c4ca0","resourceVersion":"1127454401","generation":1,"creationTimestamp":"2022-08-22T17:30:09Z","labels":{"app":"example-dc-no-service"},"managedFields":[{"manager":"Mozilla","operation":"Update","apiVersion":"apps.openshift.io/v1","time":"2022-08-22T17:30:09Z","fieldsType":"FieldsV1","fieldsV1":{"f:metadata":{"f:labels":{".":{},"f:app":{}}},"f:spec":{"f:replicas":{},"f:selector":{".":{},"f:app":{}},"f:strategy":{"f:activeDeadlineSeconds":{},"f:rollingParams":{".":{},"f:intervalSeconds":{},"f:maxSurge":{},"f:maxUnavailable":{},"f:timeoutSeconds":{},"f:updatePeriodSeconds":{}},"f:type":{}},"f:template":{".":{},"f:metadata":{".":{},"f:creationTimestamp":{},"f:labels":{".":{},"f:app":{}}},"f:spec":{".":{},"f:containers":{".":{},"k:{\"name\":\"example-dc-no-service\"}":{".":{},"f:image":{}
,"f:imagePullPolicy":{},"f:name":{},"f:ports":{".":{},"k:{\"containerPort\":8009,\"protocol\":\"TCP\"}":{".":{},"f:containerPort":{},"f:name":{},"f:protocol":{}},"k:{\"containerPort\":8080,\"protocol\":\"TCP\"}":{".":{},"f:containerPort":{},"f:name":{},"f:protocol":{}}},"f:resources":{},"f:terminationMessagePath":{},"f:terminationMessagePolicy":{}}},"f:dnsPolicy":{},"f:restartPolicy":{},"f:schedulerName":{},"f:securityContext":{},"f:terminationGracePeriodSeconds":{}}},"f:triggers":{}}}},{"manager":"openshift-controller-manager","operation":"Update","apiVersion":"apps.openshift.io/v1","time":"2022-08-22T17:30:09Z","fieldsType":"FieldsV1","fieldsV1":{"f:status":{"f:details":{".":{},"f:causes":{},"f:message":{}},"f:latestVersion":{}}},"subresource":"status"}]},"spec":{"strategy":{"type":"Rolling","rollingParams":{"updatePeriodSeconds":1,"intervalSeconds":1,"timeoutSeconds":600,"maxUnavailable":"25%","maxSurge":"25%"},"resources":{},"activeDeadlineSeconds":21600},"triggers":[{"type":"Co
nfigChange"}],"replicas":1,"revisionHistoryLimit":10,"test":false,"selector":{"app":"example-dc-no-service"},"template":{"metadata":{"creationTimestamp":null,"labels":{"app":"example-dc-no-service"}},"spec":{"containers":[{"name":"example-dc-no-service","image":"quay.io/kiegroup/process-quarkus-example:latest","ports":[{"name":"http","containerPort":8080,"protocol":"TCP"},{"name":"another-http","containerPort":8009,"protocol":"TCP"}],"resources":{},"terminationMessagePath":"/dev/termination-log","terminationMessagePolicy":"File","imagePullPolicy":"Always"}],"restartPolicy":"Always","terminationGracePeriodSeconds":30,"dnsPolicy":"ClusterFirst","securityContext":{},"schedulerName":"default-scheduler"}}},"status":{"latestVersion":1,"observedGeneration":0,"replicas":0,"updatedReplicas":0,"availableReplicas":0,"unavailableReplicas":0,"details":{"message":"config
+
{"kind":"DeploymentConfig","apiVersion":"apps.openshift.io/v1","metadata":{"name":"example-dc-no-service","namespace":"serverless-workflow-greeting-quarkus","uid":"a01d76e9-6b3a-48bf-8224-acb9de3c4ca0","resourceVersion":"1127454401","generation":1,"creationTimestamp":"2022-08-22T17:30:09Z","labels":{"app":"example-dc-no-service"},"managedFields":[{"manager":"Mozilla","operation":"Update","apiVersion":"apps.openshift.io/v1","time":"2022-08-22T17:30:09Z","fieldsType":"FieldsV1","fieldsV1":{"f:metadata":{"f:labels":{".":{},"f:app":{}}},"f:spec":{"f:replicas":{},"f:selector":{".":{},"f:app":{}},"f:strategy":{"f:activeDeadlineSeconds":{},"f:rollingParams":{".":{},"f:intervalSeconds":{},"f:maxSurge":{},"f:maxUnavailable":{},"f:timeoutSeconds":{},"f:updatePeriodSeconds":{}},"f:type":{}},"f:template":{".":{},"f:metadata":{".":{},"f:creationTimestamp":{},"f:labels":{".":{},"f:app":{}}},"f:spec":{".":{},"f:containers":{".":{},"k:{\"name\":\"example-dc-no-service\"}":{".":{},"f:image":{}
,"f:imagePullPolicy":{},"f:name":{},"f:ports":{".":{},"k:{\"containerPort\":8009,\"protocol\":\"TCP\"}":{".":{},"f:containerPort":{},"f:name":{},"f:protocol":{}},"k:{\"containerPort\":8080,\"protocol\":\"TCP\"}":{".":{},"f:containerPort":{},"f:name":{},"f:protocol":{}}},"f:resources":{},"f:terminationMessagePath":{},"f:terminationMessagePolicy":{}}},"f:dnsPolicy":{},"f:restartPolicy":{},"f:schedulerName":{},"f:securityContext":{},"f:terminationGracePeriodSeconds":{}}},"f:triggers":{}}}},{"manager":"openshift-controller-manager","operation":"Update","apiVersion":"apps.openshift.io/v1","time":"2022-08-22T17:30:09Z","fieldsType":"FieldsV1","fieldsV1":{"f:status":{"f:details":{".":{},"f:causes":{},"f:message":{}},"f:latestVersion":{}}},"subresource":"status"}]},"spec":{"strategy":{"type":"Rolling","rollingParams":{"updatePeriodSeconds":1,"intervalSeconds":1,"timeoutSeconds":600,"maxUnavailable":"25%","maxSurge":"25%"},"resources":{},"activeDeadlineSeconds":21600},"triggers":[{"type":"Co
nfigChange"}],"replicas":1,"revisionHistoryLimit":10,"test":false,"selector":{"app":"example-dc-no-service"},"template":{"metadata":{"creationTimestamp":null,"labels":{"app":"example-dc-no-service"}},"spec":{"containers":[{"name":"example-dc-no-service","image":"docker.io/apache/incubator-kie-process-quarkus-example:latest","ports":[{"name":"http","containerPort":8080,"protocol":"TCP"},{"name":"another-http","containerPort":8009,"protocol":"TCP"}],"resources":{},"terminationMessagePath":"/dev/termination-log","terminationMessagePolicy":"File","imagePullPolicy":"Always"}],"restartPolicy":"Always","terminationGracePeriodSeconds":30,"dnsPolicy":"ClusterFirst","securityContext":{},"schedulerName":"default-scheduler"}}},"status":{"latestVersion":1,"observedGeneration":0,"replicas":0,"updatedReplicas":0,"availableReplicas":0,"unavailableReplicas":0,"details":{"message":"config
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/statefulset/statefulset-no-service.yaml:
##########
@@ -36,7 +36,7 @@ spec:
spec:
containers:
- name: process-quarkus-example-statefulset-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
