tiagobento commented on code in PR #3525:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1609208579
##########
.ci/jenkins/Jenkinsfile.setup-branch:
##########
@@ -213,11 +213,11 @@ String getWorkflowCommonDeploymentRelativePath() {
String getDataIndexEphemeralImage() {
if (isMainBranch()) {
- return "${dataIndexEphemeralImageName}-nightly:latest"
+ return "${dataIndexEphemeralImageName}:main"
}
String version = getKogitoVersion()
if (version.endsWith('-SNAPSHOT')) {
- return
"${dataIndexEphemeralImageName}-nightly:${util.getMajorMinorVersion(version)}"
+ return
"${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
}
return
"${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
Review Comment:
With that said, this is not something that should only be done on the deploy
job, as the code itself needs to reflect that, so people building locally and
developing will have the same behavior. I guess the best solution would be
calling:
`mvn versions:set-property -Dproperty=data-index-ephemeral.image
-DnewVersion=<new-value>` on this module during commits D and R, as per our
release procedure described here:
https://docs.google.com/document/d/1t-08b970i9PMBy-TSM64x0RUH46pzwnIhEi-LVeL0lg/edit
This way, the deployment CI doesn't need to alter this property when
publishing, and the build from source is always accurate.
Better yet would be creating a new property to hold only have the
`tagVersion`, not the full `tag` of the image. This new property (E.g.,
`data-index-ephemeral.image.tagVersion`) can then be used to compose the
existing `data-index-ephemeral.image` property, like
`docker.io/apache/incubator-kie-kogito-data-index-ephemeral:${data-index-ephemeral.image.tagVersion}`.
Sorry for dumping the entire reasoning here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
