tiagobento commented on code in PR #3525:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1609205741
##########
.ci/jenkins/Jenkinsfile.setup-branch:
##########
@@ -213,11 +213,11 @@ String getWorkflowCommonDeploymentRelativePath() {
String getDataIndexEphemeralImage() {
if (isMainBranch()) {
- return "${dataIndexEphemeralImageName}-nightly:latest"
+ return "${dataIndexEphemeralImageName}:main"
}
String version = getKogitoVersion()
if (version.endsWith('-SNAPSHOT')) {
- return
"${dataIndexEphemeralImageName}-nightly:${util.getMajorMinorVersion(version)}"
+ return
"${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
}
return
"${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
Review Comment:
I think this needs adjustment.. For the main branch, the tag would be
`main`, that's fine. But when the branch is not `main`, we actually agreed to
use the branch name to represent the stream, so the tag of this image would be
10.0.x. Now when we're doing an ACTUAL release, meaning versions does not end
with `-SNAPSHOT`, then that's when we're supposed to use `getMajorMinor()`..
Let me know if I'm missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
