jomarko commented on code in PR #2454:
URL:
https://github.com/apache/incubator-kie-tools/pull/2454#discussion_r1704167612
##########
packages/dmn-editor/tests-e2e/drgElements/resizeDecisionService.spec.ts:
##########
@@ -304,5 +304,28 @@ test.describe("Resize node - Decision Service", () => {
expect(height).toEqual("280");
expect(width).toEqual("280");
});
+
+ test("should resize non empty Decision Service", async ({
+ decisionServicePropertiesPanel,
+ diagram,
+ nodes,
+ palette,
+ }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description:
"https://github.com/apache/incubator-kie-issues/issues/881";,
+ });
+ await diagram.resetFocus();
+ await palette.dragNewNode({ type: NodeType.DECISION, targetPosition: {
x: 400, y: 100 } });
+ await diagram.resetFocus();
+ // move into Decision Service
Review Comment:
I would like to keep this comment for now, currently we have API that works
more with coordinates. I mean, after a while, reading the test line, `await
nodes.move({ name: DefaultNodeName.DECISION, targetPosition: { x: 200, y: 200 }
});` may be not so clear the coordinates are inside a decision service node.
If we, in future introduce playwright fixture method like:
`nodes.moveInto({name, targetNodeName})` then for sure we can remove this
comment. What do you think @kbowers-ibm ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
