danielzhe commented on code in PR #2454:
URL:
https://github.com/apache/incubator-kie-tools/pull/2454#discussion_r1704644435
##########
packages/dmn-editor/tests-e2e/drgElements/resizeDecisionService.spec.ts:
##########
@@ -304,5 +304,28 @@ test.describe("Resize node - Decision Service", () => {
expect(height).toEqual("280");
expect(width).toEqual("280");
});
+
+ test("should resize non empty Decision Service", async ({
+ decisionServicePropertiesPanel,
+ diagram,
+ nodes,
+ palette,
+ }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description:
"https://github.com/apache/incubator-kie-issues/issues/881";,
+ });
+ await diagram.resetFocus();
+ await palette.dragNewNode({ type: NodeType.DECISION, targetPosition: {
x: 400, y: 100 } });
+ await diagram.resetFocus();
+ // move into Decision Service
Review Comment:
I know you didn't ask for me, but since I'm here: I had the same "issue"
with some tests I did. I think that `nodes.moveInto({name, targetNodeName})`
would be a great idea but for now, since we have another test doing exactly the
same thing, I think we should leave it as it is. Also, it can be very tricky to
do a `nodes.moveInto({name, targetNodeName})`, because consider the scenarios
when we have more than one node inside, different sizes, and so on. Probably
the user of `nodes.moveInto({name, targetNodeName})` would be expected that the
node is moved in a good position with no overlap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
