danielzhe commented on code in PR #2454:
URL:
https://github.com/apache/incubator-kie-tools/pull/2454#discussion_r1706102683
##########
packages/dmn-editor/src/propertiesPanel/DecisionServiceProperties.tsx:
##########
@@ -193,6 +196,7 @@ export function DecisionServiceProperties({
</FormGroup>
<FormGroup label="Input data">
<DraggableDecisionServiceElementList
+
elementListDataTestId={"kie-tools--dmn-editor--decision-service-input-data"}
Review Comment:
I don't think it is a good practice to add the data-testid into the logic of
the component by adding a new parameter, the `elementListDataTestId`.
What you can do is to add `data-testid` directly in the `FormGroup`:
`<FormGroup label="Input data"
data-testid={"kie-tools--dmn-editor--decision-service-input-data"}>`
And then remove the `elementListDataTestId` from the
`DraggableDecisionServiceElementList` and its nested `<ul>`.
If you need the list items inside the
`"kie-tools--dmn-editor--decision-service-input-data"`, you can do something
like this at the end:
`getByRole("listitem")`
Also, please, check the `DecisionServiceElementList` for the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
