danielzhe commented on code in PR #2509:
URL:
https://github.com/apache/incubator-kie-tools/pull/2509#discussion_r1704800387
##########
packages/feel-input-component/tests/semanticTokensProvider.test.ts:
##########
@@ -34,28 +35,39 @@ describe("Semantic Tokens Provider", () => {
/**
* The 'parsedTokens' are the tokens that parser should found in the
provided 'expression'.
* The 'expected' are the Monaco Semantic Tokens that we are expecting to
pass to Monaco to paint it on the screen.
- *
- * Each Monaco Semantic Tokens is an array of 5 positions
- * 0 = The start line of the token RELATIVE TO THE PREVIOUS LINE
- * 1 = The start index of the token relative to the START of the previous
token
- * 2 = The length of the token
- * 3 = The type of the token (GlobalVariable, Unknown, Function Parameter,
etc.). It determines the color of the token
- * 4 = Token modifier. It's always zero since we don't have this feature.
*/
test.each([
{
expression:
'This is a variable with a very long name to reproduce the issue
thousand one hundred and seventy-eight + "bar"',
- expected: [[0, 0, 102, 5, 0]],
+ expected: [
Review Comment:
I did some refactor here to make more easy and clear to understand what
those arrays are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
