danielzhe commented on code in PR #2509:
URL:
https://github.com/apache/incubator-kie-tools/pull/2509#discussion_r1704801469
##########
packages/feel-input-component/tests/semanticTokensProvider.test.ts:
##########
@@ -140,10 +223,66 @@ ThatShouldFailWhenBreakLine`,
cancellationTokenMock
);
- const expectedSemanticMonacoTokens = expected.flat();
+ for (let i = 0; i < expected.length; i++) {
+ expect(semanticMonacoTokens?.data[i]).toEqual(expected[i]);
+ }
+ });
+ });
- for (let i = 0; i < expectedSemanticMonacoTokens.length; i++) {
-
expect(semanticMonacoTokens?.data[i]).toEqual(expectedSemanticMonacoTokens[i]);
+ describe("built-in types", () => {
Review Comment:
The tests are here because in this way we can test all the code up from the
FEEL Input Component down to the parser. We could add the tests only to the
parser, but it will make lack code coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
