danielzhe commented on code in PR #2509:
URL:
https://github.com/apache/incubator-kie-tools/pull/2509#discussion_r1706040980
##########
packages/feel-input-component/tests/semanticTokensProvider.test.ts:
##########
@@ -140,10 +223,66 @@ ThatShouldFailWhenBreakLine`,
cancellationTokenMock
);
- const expectedSemanticMonacoTokens = expected.flat();
+ for (let i = 0; i < expected.length; i++) {
+ expect(semanticMonacoTokens?.data[i]).toEqual(expected[i]);
+ }
+ });
+ });
- for (let i = 0; i < expectedSemanticMonacoTokens.length; i++) {
-
expect(semanticMonacoTokens?.data[i]).toEqual(expectedSemanticMonacoTokens[i]);
+ describe("built-in types", () => {
+ test.each([
+ { type: BuiltInTypes.Number },
+ { type: BuiltInTypes.Boolean },
+ { type: BuiltInTypes.String },
+ { type: BuiltInTypes.DaysAndTimeDuration },
+ { type: BuiltInTypes.DateAndTime },
+ { type: BuiltInTypes.YearsAndMonthsDuration },
+ { type: BuiltInTypes.Time },
+ { type: BuiltInTypes.Date },
+ ])("should recognize built-in type '$type.name' properties as valid",
async ({ type }) => {
Review Comment:
Yes, that's the idea. The test checks every property for types who have
properties, here:
https://github.com/apache/incubator-kie-tools/pull/2509/files#diff-4dd09e80acb1f721571e2f04fb425b960044de59ae1116f2c6552a3b5cd1bf2bR246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
