josedee commented on PR #2820: URL: https://github.com/apache/incubator-kie-tools/pull/2820#issuecomment-2550672752
> Thank you for the pull request. I have a question about `isNil` usage. Could you please explain little bit more why we need it for: > > * `job.priority` > * `job.repeatInterval` > * `job.repeatLimit` > > while we do not need it for: > > * `job.scheduleId` > * `job.callbackEndpoint` > > usually our effort is to minimize the need of used libraries. So just doublechecking if we need to introduce a dependency for `lodash.isNil` in this file. As seen in [this screenshot](https://private-user-images.githubusercontent.com/159427631/396797874-a590c4d3-ecad-49cf-bf22-2d867a8a378b.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ1MDk4NjAsIm5iZiI6MTczNDUwOTU2MCwicGF0aCI6Ii8xNTk0Mjc2MzEvMzk2Nzk3ODc0LWE1OTBjNGQzLWVjYWQtNDljZi1iZjIyLTJkODY3YThhMzc4Yi5qcGVnP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTIxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEyMThUMDgxMjQwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDFjMzgwMThlOTkyZDAyMzkzYjQ3M2Q3ZDYyYTg1ZjUyMGMzNjM0MGJmNzUwNDA2ODNlNDk5NDFhODI1YWRmNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.DhpNPZHKJai9JDzE9GtQBSkLtdTdallh_pTBor2vKt8), priority, repeatInterval and repeatLimit weren't displayed correctly. In this example priority was either null/undefined, repeatInterval and repeatLimit are boths 0's. All three are numbers. I did this to display them when they are also 0. So 0 is considered truthy. callbackEndpoint and scheduledId are both strings hence not requiring stringent validation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
