ljmotta commented on code in PR #2820:
URL:
https://github.com/apache/incubator-kie-tools/pull/2820#discussion_r1890079720
##########
packages/runtime-tools-process-enveloped-components/src/jobsManagement/envelope/components/JobsDetailsModal/JobsDetailsModal.tsx:
##########
@@ -93,7 +104,7 @@ export const JobsDetailsModal: React.FC<IOwnProps &
OUIAProps> = ({
</Split>
</FlexItem>
)}
- {job.repeatLimit && (
+ {!isNil(job.repeatLimit) && (
Review Comment:
same
##########
packages/runtime-tools-process-enveloped-components/src/jobsManagement/envelope/components/JobsDetailsModal/JobsDetailsModal.tsx:
##########
@@ -70,20 +71,30 @@ export const JobsDetailsModal: React.FC<IOwnProps &
OUIAProps> = ({
<FlexItem>
<Split hasGutter>
<SplitItem>
- <Text component={TextVariants.h6}>Status: </Text>{" "}
+ <Text component={TextVariants.h6}>NodeInstanceId: </Text>
</SplitItem>
- <SplitItem>{job.status}</SplitItem>
+ <SplitItem>{job.nodeInstanceId}</SplitItem>
</Split>
</FlexItem>
<FlexItem>
<Split hasGutter>
<SplitItem>
- <Text component={TextVariants.h6}>Priority: </Text>{" "}
+ <Text component={TextVariants.h6}>Status: </Text>{" "}
</SplitItem>
- <SplitItem>{job.priority}</SplitItem>
+ <SplitItem>{job.status}</SplitItem>
</Split>
</FlexItem>
- {job.repeatInterval && (
+ {!isNil(job.priority) && (
Review Comment:
`job.priority` is from type `number`, you don't need to check if it will be
`null` or `undefined`.
##########
packages/runtime-tools-process-enveloped-components/src/jobsManagement/envelope/components/JobsDetailsModal/JobsDetailsModal.tsx:
##########
@@ -70,20 +71,30 @@ export const JobsDetailsModal: React.FC<IOwnProps &
OUIAProps> = ({
<FlexItem>
<Split hasGutter>
<SplitItem>
- <Text component={TextVariants.h6}>Status: </Text>{" "}
+ <Text component={TextVariants.h6}>NodeInstanceId: </Text>
</SplitItem>
- <SplitItem>{job.status}</SplitItem>
+ <SplitItem>{job.nodeInstanceId}</SplitItem>
</Split>
</FlexItem>
<FlexItem>
<Split hasGutter>
<SplitItem>
- <Text component={TextVariants.h6}>Priority: </Text>{" "}
+ <Text component={TextVariants.h6}>Status: </Text>{" "}
</SplitItem>
- <SplitItem>{job.priority}</SplitItem>
+ <SplitItem>{job.status}</SplitItem>
</Split>
</FlexItem>
- {job.repeatInterval && (
+ {!isNil(job.priority) && (
+ <FlexItem>
+ <Split hasGutter>
+ <SplitItem>
+ <Text component={TextVariants.h6}>Priority: </Text>{" "}
+ </SplitItem>
+ <SplitItem>{job.priority}</SplitItem>
+ </Split>
+ </FlexItem>
+ )}
+ {!isNil(job.repeatInterval) && (
Review Comment:
`job.repeatInterval` is from type `number` as well.
##########
packages/runtime-tools-process-enveloped-components/src/jobsManagement/envelope/components/JobsDetailsModal/JobsDetailsModal.tsx:
##########
@@ -26,6 +26,7 @@ import Moment from "react-moment";
import "../styles.css";
import { Job } from "@kie-tools/runtime-tools-process-gateway-api/dist/types";
import { OUIAProps, componentOuiaProps } from
"@kie-tools/runtime-tools-components/dist/ouiaTools";
+import isNil from "lodash/isNil";
Review Comment:
Please, use the inline check (`<value> === undefined` or `<value> !==
undefined`) instead of using a library to do so. This method checks if the
value is `null` or `undefined` [1], and looking in the `Job` type, we don't
have one case that can have those two values.
[1] https://lodash.com/docs#isNil
##########
packages/runtime-tools-process-enveloped-components/src/processDetails/envelope/components/ProcessDetailsTimelinePanel/ProcessDetailsTimelinePanel.tsx:
##########
@@ -342,23 +342,19 @@ const ProcessDetailsTimelinePanel: React.FC<IOwnProps &
OUIAProps> = ({
};
const renderTimerIcon = (id: string) => {
- return jobs.length > 0 ? (
- jobs.map((job, idx) => {
- if (id === job.nodeInstanceId) {
- return (
- <Tooltip content={"Node has job"} key={idx}>
- <OutlinedClockIcon
- className="pf-u-ml-sm"
- color="var(--pf-global--icon--Color--dark)"
- onClick={() => handleJobDetails(job)}
- />
- </Tooltip>
- );
- }
- })[0]
- ) : (
- <></>
- );
+ const job = jobs.find((job) => id === job.nodeInstanceId);
+ if (job) {
+ return (
+ <Tooltip content={"Node has job"} key={`${id}-job-tooltip-${job.id}`}>
+ <OutlinedClockIcon
+ className="pf-u-ml-sm"
+ color="var(--pf-global--icon--Color--dark)"
+ onClick={() => handleJobDetails(job)}
+ />
+ </Tooltip>
+ );
+ }
+ return <></>;
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
