josedee commented on code in PR #2820:
URL:
https://github.com/apache/incubator-kie-tools/pull/2820#discussion_r1890469903
##########
packages/runtime-tools-process-enveloped-components/src/jobsManagement/envelope/components/JobsDetailsModal/JobsDetailsModal.tsx:
##########
@@ -70,20 +71,30 @@ export const JobsDetailsModal: React.FC<IOwnProps &
OUIAProps> = ({
<FlexItem>
<Split hasGutter>
<SplitItem>
- <Text component={TextVariants.h6}>Status: </Text>{" "}
+ <Text component={TextVariants.h6}>NodeInstanceId: </Text>
</SplitItem>
- <SplitItem>{job.status}</SplitItem>
+ <SplitItem>{job.nodeInstanceId}</SplitItem>
</Split>
</FlexItem>
<FlexItem>
<Split hasGutter>
<SplitItem>
- <Text component={TextVariants.h6}>Priority: </Text>{" "}
+ <Text component={TextVariants.h6}>Status: </Text>{" "}
</SplitItem>
- <SplitItem>{job.priority}</SplitItem>
+ <SplitItem>{job.status}</SplitItem>
</Split>
</FlexItem>
- {job.repeatInterval && (
+ {!isNil(job.priority) && (
Review Comment:
Thanks for the suggestions @ljmotta. I think we can use `===` or `!==` but
one thing I think in the bug screenshot attached `job.priority` is displayed as
`Priority: ` without applying any validations. In that case I think it maybe
`null/undefined`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
