rhkp commented on code in PR #2790:
URL:
https://github.com/apache/incubator-kie-tools/pull/2790#discussion_r1920818714
##########
packages/sonataflow-operator/operator.yaml:
##########
@@ -19403,9 +19422,14 @@ spec:
for the workflow
maxProperties: 2
properties:
- migrateDBOnStartUp:
- description: Whether to migrate database on service
startup?
- type: boolean
+ dbMigrationStrategy:
Review Comment:
@wmedvede
- This is added by `make generate-all` command automatically.
- This is being added even though `DBMigrationStrategy` is annotated with
`+optional`, operator-sdk adds it in `operator.yaml`. Please see
[this](https://github.com/apache/incubator-kie-tools/blob/ab197e99ea446da684baa2a533a68413e2e23e22/packages/sonataflow-operator/api/v1alpha08/sonataflow_persistence_types.go#L69).
- Also, as the `PersistenceOptionsSpec` is included in
[sonataflow_types.go](https://github.com/apache/incubator-kie-tools/blob/ab197e99ea446da684baa2a533a68413e2e23e22/packages/sonataflow-operator/api/v1alpha08/sonataflow_types.go#L147)
by SonataFlowSpec struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
