rhkp commented on PR #2790: URL: https://github.com/apache/incubator-kie-tools/pull/2790#issuecomment-2631931280
> Hi @rhkp , while doing some testing I have found a small issue in the DB Migrator: > > Let me explain: > > A database produced by the DB Migrator looks like this: > >  > > On the other hand, if we start the data index service (not using the db migrator) and we enable flyway for the data index, we can see a database like this: > >  > > So we have a 1.5.0 and 1.5.1 files that are included by the data index service but not by the db migrator. > > This is basically because the data index service has a dependency on the `persistence-commons` module that incorporates the missing files. > > Your work is good! but we need to make the db migrator incorporate the .sql files provided by that module. > > See here in the db migrator build structure: > >  > > would you mind take a look ? Hi @wmedvede / @ricardozanini, Please note we are using maven's [`maven-dependency-plugin`](https://github.com/rhkp/incubator-kie-tools/blob/main/packages/kogito-db-migrator-tool/pom.xml#L69) to download ddl files dynamically and use them for DB migration for DI & JS . Should not all the sql files needed by data-index and jobs-service be available from zip file that we download with maven-dependency-plugin? Please advise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
