wmedvede commented on code in PR #2790: URL: https://github.com/apache/incubator-kie-tools/pull/2790#discussion_r1922267074
########## packages/sonataflow-operator/config/manifests/bases/sonataflow-operator.clusterserviceversion.yaml: ########## Review Comment: @rhkp your observation is good, and mine too :thinking: Rethinking here, It looks like we have a sort of outdated (and not necessarily outdated) specification of the CustomResourceDefinitions in this file... i.e., not all the fields were always added to the respective CRDs. Some fields were added, and some other don't. For example: we have things like `path: services.jobService.podTemplate` but we don't have things like `services.jobService.persistence` Which makes me think that not all the fields for the different CRDs owned by this operator where added to this file along the time. Question is, do we need them all added there? I think that not, see below. Also, by looking at here: https://olm.operatorframework.io/docs/concepts/crds/clusterserviceversion I think the full specification of each CRD in that list is not needed (that information is not used for creating the respective CRDs), instead we could just only declare file the list of owned resources by this operator.... @ricardozanini is my reasoning correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
