danielzhe commented on code in PR #2975:
URL:
https://github.com/apache/incubator-kie-tools/pull/2975#discussion_r1985647389
##########
packages/dmn-feel-antlr4-parser/src/parser/IdentifiersRepository.ts:
##########
@@ -209,9 +210,9 @@ export class IdentifiersRepository {
}
private loadIdentifiersFromInputData(drg: DmnInputData) {
- this.addIdentifier({
+ this.addIdentifierContext({
Review Comment:
This change is to make more clear what this method does. The previous name
gives the false sense that we was just "adding identifiers" but the true is
that we are adding identifiers context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
