danielzhe commented on code in PR #2975:
URL:
https://github.com/apache/incubator-kie-tools/pull/2975#discussion_r1985651633
##########
packages/dmn-feel-antlr4-parser/src/parser/IdentifiersRepository.ts:
##########
@@ -759,38 +760,57 @@ export class IdentifiersRepository {
}
private addDecisionTableEntryNode(parent: IdentifierContext, entryNode:
ExpressionSource) {
- const ruleInputElementNode = this.addIdentifier({
+ const ruleInputElementNode = this.addIdentifierContext({
uuid: entryNode["@_id"] ?? "",
- name: "",
+ identifierDefinedByTheContext: "",
kind: FeelSyntacticSymbolNature.LocalVariable,
parentContext: parent,
});
parent.children.set(ruleInputElementNode.uuid, ruleInputElementNode);
this.addExpression(parent, entryNode);
}
+ private addDecisionTableInputEntryNode(parent: IdentifierContext,
inputEntryNode: DMN15__tInputClause) {
Review Comment:
This is the real bug fix.
What we are doing here is telling to the repository "hey, this object that
is in the Decision Table is a context that recognize variables and have this
expression inside of it. Do your thing."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
