danielzhe commented on code in PR #2975:
URL:
https://github.com/apache/incubator-kie-tools/pull/2975#discussion_r1985649374
##########
packages/dmn-feel-antlr4-parser/src/parser/IdentifiersRepository.ts:
##########
@@ -209,9 +210,9 @@ export class IdentifiersRepository {
}
private loadIdentifiersFromInputData(drg: DmnInputData) {
- this.addIdentifier({
+ this.addIdentifierContext({
uuid: drg["@_id"] ?? "",
- name: drg["@_name"],
+ identifierDefinedByTheContext: drg["@_name"],
Review Comment:
Some contexts define identifiers, others are just contexts for identifiers.
This needs some refactoring in the future to be optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
