gabriel-farache commented on PR #3944: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3944#issuecomment-3018604028
> Looks good to me, however I'm wondering if other rainy tests could be added as well for testing the resilience and robustness of the system, just like: > > * Missing/invalid _xauthorizationsimple_ header > * Malformed CloudEvent > * Wrong token in header > * External service failure > > Wdyt? @gmunozfe The goal of those tests are not to verify the workflow itself but rather simply verify that if a workflow is triggered but a CloudEvent, the headers it holds are correctfully provided to the openapi generator so it can use them, for instance, to propagate token So testing anything related to the correctfulness of the workflow triggered by the CloudEvent are out of the scope, this should be delegated to the end user implementing its own workflow If there is a Malformed CloudEvent, the workflow would never be triggered so the goal of the test cannot be fulfil anyway -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
