yesamer commented on code in PR #6429:
URL:
https://github.com/apache/incubator-kie-drools/pull/6429#discussion_r2290100727
##########
build-parent/pom.xml:
##########
@@ -1899,11 +1901,6 @@
<artifactId>frontend-maven-plugin</artifactId>
<version>${version.com.github.eirslett}</version>
</plugin>
- <plugin>
- <groupId>com.societegenerale.commons</groupId>
- <artifactId>arch-unit-maven-plugin</artifactId>
- <version>${archunit.maven.plugin.version}</version>
- </plugin>
<plugin>
Review Comment:
@ChinchuAjith Please restore this
##########
build-parent/pom.xml:
##########
@@ -2404,6 +2401,54 @@
</plugins>
</build>
</profile>
+
+ <profile>
+ <id>archunit-java17</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ <jdk>17</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.societegenerale.commons</groupId>
+ <artifactId>arch-unit-maven-plugin</artifactId>
+ <version>2.9.1</version> <!-- Compatible with Java 17 -->
+ <executions>
+ <execution>
+ <goals>
+ <goal>arch-test</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+
+ <!-- Profile for Java 21 -->
+ <profile>
+ <id>archunit-java21</id>
+ <activation>
+ <jdk>21</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.societegenerale.commons</groupId>
Review Comment:
@ChinchuAjith You don't need to declare the plugin, it's enough to override
the version property:
```
<id>jdk-21</id>
<activation>
<jdk>[21,)</jdk>
</activation>
<properties>
<archunit.maven.plugin.version>4.0.2</archunit.maven.plugin.version>
</properties>
```
##########
build-parent/pom.xml:
##########
@@ -221,7 +221,9 @@
<version.download-maven-plugin>2.0.0</version.download-maven-plugin>
<version.property-maven-plugin>1.2.1</version.property-maven-plugin>
<!-- plugin used to enforce architectural constraints -->
- <archunit.maven.plugin.version>2.9.1</archunit.maven.plugin.version>
+ <!--Added JDK-specific ArchUnit plugin profiles for Java 17 and Java 21.
+ Commented out the global plugin declaration to prevent version mismatch.-->
+ <!--<archunit.maven.plugin.version>3.0.1</archunit.maven.plugin.version>-->
Review Comment:
@ChinchuAjith Please restore the version here, the one compatible with JDK 17
##########
build-parent/pom.xml:
##########
@@ -2404,6 +2401,54 @@
</plugins>
</build>
</profile>
+
+ <profile>
Review Comment:
@ChinchuAjith Please remove the jdk 17 profile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
