ChinchuAjith commented on code in PR #6429:
URL:
https://github.com/apache/incubator-kie-drools/pull/6429#discussion_r2292700386
##########
build-parent/pom.xml:
##########
@@ -1900,9 +1900,16 @@
<version>${version.com.github.eirslett}</version>
</plugin>
<plugin>
- <groupId>com.societegenerale.commons</groupId>
- <artifactId>arch-unit-maven-plugin</artifactId>
- <version>${archunit.maven.plugin.version}</version>
+ <groupId>com.societegenerale.commons</groupId>
+ <artifactId>arch-unit-maven-plugin</artifactId>
+ <version>${archunit.maven.plugin.version}</version>
+ <executions>
+ <execution>
+ <goals>
+ <goal>arch-test</goal>
+ </goals>
+ </execution>
+ </executions>
Review Comment:
I'm not entirely sure whether we are currently running ArchUnit rules
separately via the Maven plugin or just through JUnit tests. However, if we are
using the Maven plugin to run architectural rules, then the <executions> block
is required. This block binds the arch-test goal to the Maven build lifecycle,
ensuring that architectural rules are executed automatically during the build
process.
So, if we’re relying on the Maven plugin (not just JUnit), this
configuration is necessary. If not, and we’re only using archunit-junit5 in
test scope, we might be able to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
