yesamer commented on code in PR #6429:
URL:
https://github.com/apache/incubator-kie-drools/pull/6429#discussion_r2291539226
##########
build-parent/pom.xml:
##########
@@ -221,7 +221,7 @@
<version.download-maven-plugin>2.0.0</version.download-maven-plugin>
<version.property-maven-plugin>1.2.1</version.property-maven-plugin>
<!-- plugin used to enforce architectural constraints -->
- <archunit.maven.plugin.version>2.9.1</archunit.maven.plugin.version>
+ <archunit.maven.plugin.version>4.0.2</archunit.maven.plugin.version>
Review Comment:
@ChinchuAjith Not part of your change, but can you please rename this
version use the same convention used for all other dependencies ? eg.
`archunit.maven.plugin.version` to `version.archunit-maven-plugin`
##########
build-parent/pom.xml:
##########
@@ -2404,6 +2411,18 @@
</plugins>
</build>
</profile>
+
+ <profile>
+ <id>archunit-java17</id>
+ <activation>
+ <jdk>[17,18)</jdk>
Review Comment:
@ChinchuAjith This should be activated to any version in the 17 - 20 range
##########
build-parent/pom.xml:
##########
@@ -1900,9 +1900,16 @@
<version>${version.com.github.eirslett}</version>
</plugin>
<plugin>
- <groupId>com.societegenerale.commons</groupId>
- <artifactId>arch-unit-maven-plugin</artifactId>
- <version>${archunit.maven.plugin.version}</version>
+ <groupId>com.societegenerale.commons</groupId>
+ <artifactId>arch-unit-maven-plugin</artifactId>
+ <version>${archunit.maven.plugin.version}</version>
+ <executions>
+ <execution>
+ <goals>
+ <goal>arch-test</goal>
+ </goals>
+ </execution>
+ </executions>
Review Comment:
@ChinchuAjith Why is this executions required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
