gitgabrio commented on code in PR #6704:
URL:
https://github.com/apache/incubator-kie-drools/pull/6704#discussion_r3411581126
##########
kie-api/src/main/java/org/kie/api/runtime/KieRuntime.java:
##########
@@ -23,6 +23,13 @@
import org.kie.api.runtime.rule.RuleRuntime;
import org.kie.api.time.SessionClock;
+/**
+ * KieRuntime provides runtime capabilities for rule and process execution.
+ * Extends RuntimeSession for common session operations.
+ * @since 10.1.0
Review Comment:
HI @yesamer
I'm afraid there is some sort of misalignment about introduction version.
I'm sure KieRuntime is way older than 10.1.0, and this is demonstrated by the
following (e.g.):
```java
@Deprecated(since = "6.0.0", forRemoval = true)
KieRuntime getKnowledgeRuntime();
```
I think the confusion may be due to the fact that at a given point multiple
repositories get merged in a single one.
Please take a look at [6.5.0
API](https://docs.drools.org/6.5.0.Final/kie-api-javadoc/) (again, e.g.)
##########
kie-api/src/main/java/org/kie/api/command/KieCommands.java:
##########
@@ -151,6 +158,13 @@ Command newCompleteWorkItem(long workItemId,
Command<Long> newAdvanceSessionTime(long amount, TimeUnit unit);
Command<Long> newAdvanceSessionTime(long amount, TimeUnit unit, String
outIdentifier);
+ /**
+ * Creates a command to apply a PMML model.
+ * @param request the PMML request data as a Map
+ * @return the command
+ * @since 10.2.0
Review Comment:
@yesamer
This was introduced in some 8.x version (see [8.39.0 FInal
API](https://docs.drools.org/8.39.0.Final/kie-api-javadoc/org/kie/api/command/KieCommands.html)
##########
kie-api/src/main/java/org/kie/api/runtime/StatelessKieSession.java:
##########
@@ -29,6 +29,10 @@
* shot method that will internally instantiate a KieSession, add all the user
data and execute user commands, call fireAllRules, and then
* call dispose(). While the main way to work with this class is via the
BatchExecution Command as supported by the CommandExecutor interface,
* two convenience methods are provided for when simple object insertion is
all that's required.
+ * Extends RuntimeSession for common session operations.
+ * @since 10.1.0
Review Comment:
@yesamer
This is one of the oldest API, AFAIK
##########
kie-api/src/main/java/org/kie/api/runtime/RuntimeSession.java:
##########
@@ -22,6 +22,12 @@
import java.util.Map;
+/**
+ * Common interface for runtime session operations shared by stateful and
stateless sessions.
+ * @since 10.1.0
+ * @apiNote Use this interface when writing code that works with both
KieRuntime
+ * and StatelessKieSession to avoid coupling to specific session
types.
+ */
Review Comment:
@yesamer ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
