yesamer commented on code in PR #6704:
URL: 
https://github.com/apache/incubator-kie-drools/pull/6704#discussion_r3411887569


##########
kie-api/src/main/java/org/kie/api/command/KieCommands.java:
##########
@@ -151,6 +158,13 @@ Command newCompleteWorkItem(long workItemId,
     Command<Long> newAdvanceSessionTime(long amount, TimeUnit unit);
     Command<Long> newAdvanceSessionTime(long amount, TimeUnit unit, String 
outIdentifier);
 
+    /**
+     * Creates a command to apply a PMML model.
+     * @param request the PMML request data as a Map
+     * @return the command
+     * @since 10.2.0

Review Comment:
   @gitgabrio In this case, it is correct. The API changed from:
   `newApplyPmmlModel(PMMLRequestData request)
   `to:
   `newApplyPmmlModel(Map<String, Object> request);`
   
   The latter is considered a new API that replaces the previous one (which 
would have been deprecated). Removing the old API results in a breaking change 
for the end user.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to