yesamer commented on code in PR #6704: URL: https://github.com/apache/incubator-kie-drools/pull/6704#discussion_r3412014338
########## kie-api/src/main/java/org/kie/api/runtime/RuntimeSession.java: ########## @@ -22,6 +22,12 @@ import java.util.Map; +/** + * Common interface for runtime session operations shared by stateful and stateless sessions. + * @since 10.1.0 + * @apiNote Use this interface when writing code that works with both KieRuntime + * and StatelessKieSession to avoid coupling to specific session types. + */ Review Comment: @gitgabrio This is a subtle case. `RuntimeSession` doesn't exist before 10.1.0. It was part of a PR that refactored a bit existing methods and move them in a new dedicated Interface https://github.com/apache/incubator-kie-drools/commit/7d11b928a43b3f47bda6aac9ae4f79000d3ece72#diff-bbea2b45c9407240a0b8b1577301021eab283168b1c90b4738c5d76c1d7fc735. So, despite the methods already exists previously in other interfaces, `RuntimeSession` was introduced in 10.1.0, so I guess it's correct to keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
