martinweiler commented on code in PR #4318:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4318#discussion_r3432884980
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ErrorEventTest.java:
##########
@@ -271,11 +258,8 @@ public void beforeNodeTriggered(ProcessNodeTriggeredEvent
event) {
workItem = workItems.get(1);
}
-
kruntime.getKogitoWorkItemManager().completeWorkItem(workItem.getStringId(),
emptyMap());
- assertProcessInstanceFinished(processInstance, kruntime);
- assertProcessInstanceAborted(processInstance);
- assertNodeTriggered(processInstance.getStringId(), "start", "split",
"User Task", "User task error attached", "error end event");
- assertNotNodeTriggered(processInstance.getStringId(), "Script Task",
"error1", "error2");
+ processInstance.completeWorkItem(workItem.getStringId(), emptyMap());
+
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_COMPLETED);
Review Comment:
In the original test the process ended up in STATE_ABORTED after the error
handling. Why is it completed now?
Also, the additional assert statements should still be kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
