SUNILathulya commented on code in PR #4318:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4318#discussion_r3441736188
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ErrorEventTest.java:
##########
@@ -147,37 +147,27 @@ public void afterNodeLeft(ProcessNodeLeftEvent event) {
@Test
public void testEventSubprocessErrorThrowOnTask() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/error/BPMN2-EventSubprocessError.bpmn2");
- final List<String> executednodes = new ArrayList<>();
- KogitoProcessEventListener listener = new
DefaultKogitoProcessEventListener() {
-
- @Override
- public void afterNodeLeft(ProcessNodeLeftEvent event) {
- if (event.getNodeInstance().getNodeName()
- .equals("Script Task 1")) {
- executednodes.add(((KogitoNodeInstance)
event.getNodeInstance()).getStringId());
- }
- }
-
- };
- kruntime.getProcessEventManager().addEventListener(listener);
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task", new TestWorkItemHandler() {
+ Application app = ProcessTestHelper.newApplication();
+ // Handler that throws MyError when activated
+ TestWorkItemHandler handler = new TestWorkItemHandler() {
@Override
- public Optional<WorkItemTransition>
activateWorkItemHandler(KogitoWorkItemManager manager, KogitoWorkItemHandler
handler, KogitoWorkItem workItem, WorkItemTransition transition) {
+ public Optional<WorkItemTransition>
activateWorkItemHandler(KogitoWorkItemManager manager,
+ KogitoWorkItemHandler handler, KogitoWorkItem workItem,
WorkItemTransition transition) {
throw new MyError();
}
+ };
- });
-
- KogitoProcessInstance processInstance =
kruntime.startProcess("EventSubprocessError");
+ ProcessTestHelper.registerHandler(app, "Human Task", handler);
- assertProcessInstanceFinished(processInstance, kruntime);
- assertProcessInstanceAborted(processInstance);
- assertNodeTriggered(processInstance.getStringId(), "start", "User Task
1",
- "Sub Process 1", "start-sub", "Script Task 1", "end-sub");
- assertThat(executednodes).hasSize(1);
+ Process<EventSubprocessErrorModel> processDefinition =
EventSubprocessErrorProcess.newProcess(app);
+ EventSubprocessErrorModel model = processDefinition.createModel();
+ org.kie.kogito.process.ProcessInstance<EventSubprocessErrorModel>
processInstance =
+ processDefinition.createInstance(model);
+ processInstance.start();
+ // Verify process finished and was aborted (error was caught by event
subprocess)
+
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_ABORTED);
Review Comment:
Fixed in
[da6c0fa](https://github.com/apache/incubator-kie-kogito-runtimes/pull/4318/commits/da6c0fa1e5e743448a557fc74344830a2a1f0dc3)
Added event listener to track executed nodes and assertion to verify event
subprocess script task execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
