SUNILathulya commented on code in PR #4318:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4318#discussion_r3441749131
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ErrorEventTest.java:
##########
@@ -271,11 +258,8 @@ public void beforeNodeTriggered(ProcessNodeTriggeredEvent
event) {
workItem = workItems.get(1);
}
-
kruntime.getKogitoWorkItemManager().completeWorkItem(workItem.getStringId(),
emptyMap());
- assertProcessInstanceFinished(processInstance, kruntime);
- assertProcessInstanceAborted(processInstance);
- assertNodeTriggered(processInstance.getStringId(), "start", "split",
"User Task", "User task error attached", "error end event");
- assertNotNodeTriggered(processInstance.getStringId(), "Script Task",
"error1", "error2");
+ processInstance.completeWorkItem(workItem.getStringId(), emptyMap());
+
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_COMPLETED);
Review Comment:
Fixed in
[da6c0fa](https://github.com/apache/incubator-kie-kogito-runtimes/pull/4318/commits/da6c0fa1e5e743448a557fc74344830a2a1f0dc3)
**Re: Process state change**
The process now ends in STATE_COMPLETED instead of STATE_ABORTED. This is
correct v9 behavior - when an error is caught and handled by a boundary event,
the process completes successfully. The v7 STATE_ABORTED was misleading since
the error was actually handled.
**Re: Assertions**
All node verification assertions have been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
