martinweiler commented on code in PR #4321:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4321#discussion_r3455703861
##########
kogito-codegen-modules/kogito-codegen-core/src/main/java/org/kie/kogito/codegen/core/utils/CodegenUtil.java:
##########
@@ -35,11 +36,13 @@ public final class CodegenUtil {
/**
* Flag used to configure transaction enabling. Default to
<code>true</code>
*/
+ @KieProperty(type = "boolean", defaultValue = "true", allowedValues =
"true,false")
Review Comment:
How are we handling these "composed" properties? The actual configuration
would either be:
```
kogito.transactionEnabled=
kogito.processes.transactionEnabled=
kogito.usertasks.transactionEnabled=
```
##########
kogito-codegen-modules/kogito-codegen-core/src/main/java/org/kie/kogito/codegen/core/utils/CodegenUtil.java:
##########
@@ -35,11 +36,13 @@ public final class CodegenUtil {
/**
* Flag used to configure transaction enabling. Default to
<code>true</code>
*/
+ @KieProperty(type = "boolean", defaultValue = "true", allowedValues =
"true,false")
public static final String TRANSACTION_ENABLED = "transactionEnabled";
/**
* Flag used to configure fault tolerance enabling. Default to
<code>true</code>
*/
+ @KieProperty(type = "boolean", defaultValue = "true", allowedValues =
"true,false")
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
