pefernan commented on code in PR #4321:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4321#discussion_r3457491896
##########
api/kogito-events-core/src/main/java/org/kie/kogito/event/AbstractDataEvent.java:
##########
@@ -71,13 +72,15 @@ public abstract class AbstractDataEvent<T> implements
DataEvent<T> {
* Since this is a required field, the constructor will fill them with
this default value.
* Ideally, callers would use #TYPE_FORMAT to fill this field using the
process name and the signal node name, e.g: process.travelagency.visaapproved
*/
+ @KieInternal
public static final String TYPE_PREFIX = "process";
public static final String TYPE_FORMAT = TYPE_PREFIX + ".%s.%s";
/**
* String format for Kogito CloudEvents source fields.
* Since this is a required field, the constructor will fill them with
default value, e.g.: /process/travelagency
* See more about the source format:
https://github.com/cloudevents/spec/blob/v1.0/spec.md#source-1
*/
+ @KieInternal
Review Comment:
same here
##########
api/kogito-services/src/main/java/org/kie/kogito/services/context/ProcessInstanceContext.java:
##########
@@ -47,12 +48,14 @@ public final class ProcessInstanceContext {
* MDC key used to store the process instance ID.
* This key should be referenced in logging configurations.
*/
+ @KieInternal
Review Comment:
same
##########
api/kogito-events-core/src/main/java/org/kie/kogito/event/AbstractDataEvent.java:
##########
@@ -71,13 +72,15 @@ public abstract class AbstractDataEvent<T> implements
DataEvent<T> {
* Since this is a required field, the constructor will fill them with
this default value.
* Ideally, callers would use #TYPE_FORMAT to fill this field using the
process name and the signal node name, e.g: process.travelagency.visaapproved
*/
+ @KieInternal
Review Comment:
I don't think this is a config, it can be removed
##########
kogito-codegen-modules/kogito-codegen-api/src/main/java/org/kie/kogito/codegen/api/utils/KogitoCodeGenConstants.java:
##########
@@ -18,18 +18,26 @@
*/
package org.kie.kogito.codegen.api.utils;
+import org.kie.api.annotations.KieInternal;
+import org.kie.api.annotations.KieProperty;
+
public class KogitoCodeGenConstants {
private KogitoCodeGenConstants() {
}
+ @KieInternal
Review Comment:
not property
##########
kogito-codegen-modules/kogito-codegen-api/src/main/java/org/kie/kogito/codegen/api/utils/KogitoCodeGenConstants.java:
##########
@@ -18,18 +18,26 @@
*/
package org.kie.kogito.codegen.api.utils;
+import org.kie.api.annotations.KieInternal;
+import org.kie.api.annotations.KieProperty;
+
public class KogitoCodeGenConstants {
private KogitoCodeGenConstants() {
}
+ @KieInternal
public static final String VALIDATION_CLASS =
"jakarta.validation.constraints.NotNull";
+ @KieInternal
public static final String OPENAPI_SPEC_CLASS =
"org.eclipse.microprofile.openapi.annotations.media.Schema";
+ @KieInternal
Review Comment:
not property
##########
quarkus/addons/knative/eventing/runtime/src/main/java/org/kie/kogito/addons/quarkus/knative/eventing/KnativeEventingConfigSource.java:
##########
@@ -31,6 +32,7 @@ public class KnativeEventingConfigSource implements
ConfigSource {
/**
* Environment variable injected by Knative
*/
+ @KieInternal
Review Comment:
same
##########
kogito-codegen-modules/kogito-codegen-core/src/main/java/org/kie/kogito/codegen/core/utils/CodegenUtil.java:
##########
@@ -35,11 +36,13 @@ public final class CodegenUtil {
/**
* Flag used to configure transaction enabling. Default to
<code>true</code>
*/
+ @KieProperty(type = "boolean", defaultValue = "true", allowedValues =
"true,false")
Review Comment:
+1
##########
kogito-codegen-modules/kogito-codegen-processes/src/main/java/org/kie/kogito/codegen/process/persistence/PersistenceGenerator.java:
##########
@@ -106,6 +120,7 @@ public class PersistenceGenerator extends AbstractGenerator
{
/**
* Generic PersistenceGenerator constants
*/
+ @KieInternal
Review Comment:
same
##########
jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/xml/core/ExtensibleXmlParser.java:
##########
@@ -74,6 +75,7 @@ public class ExtensibleXmlParser extends DefaultHandler
implements Parser {
public static final String ENTITY_RESOLVER_PROPERTY_NAME =
"org.drools.core.io.EntityResolver";
/** Namespace URI for the general tags. */
+ @KieInternal
Review Comment:
same
##########
kogito-codegen-modules/kogito-codegen-processes/src/main/java/org/kie/kogito/codegen/process/persistence/PersistenceGenerator.java:
##########
@@ -70,12 +72,19 @@ public class PersistenceGenerator extends AbstractGenerator
{
/**
* Type of persistence
*/
+ @KieInternal
public static final String FILESYSTEM_PERSISTENCE_TYPE = "filesystem";
+ @KieInternal
public static final String INFINISPAN_PERSISTENCE_TYPE = "infinispan";
+ @KieInternal
public static final String MONGODB_PERSISTENCE_TYPE = "mongodb";
+ @KieInternal
public static final String POSTGRESQL_PERSISTENCE_TYPE = "postgresql";
+ @KieInternal
public static final String KAFKA_PERSISTENCE_TYPE = "kafka";
+ @KieInternal
public static final String JDBC_PERSISTENCE_TYPE = "jdbc";
+ @KieInternal
Review Comment:
All those are not properties
##########
api/kogito-services/src/main/java/org/kie/kogito/services/context/ProcessInstanceContext.java:
##########
@@ -47,12 +48,14 @@ public final class ProcessInstanceContext {
* MDC key used to store the process instance ID.
* This key should be referenced in logging configurations.
*/
+ @KieInternal
public static final String MDC_PROCESS_INSTANCE_KEY = "processInstanceId";
/**
* Default value used when no process instance ID is available.
* Empty string for cleaner log formatting and easier searching.
*/
+ @KieInternal
Review Comment:
same
##########
kogito-codegen-modules/kogito-codegen-processes/src/main/java/org/kie/kogito/codegen/process/persistence/PersistenceGenerator.java:
##########
@@ -85,16 +94,21 @@ public class PersistenceGenerator extends AbstractGenerator
{
/**
* (boolean) enable/disable proto generation for DATA-INDEX; default to
true
*/
+ @KieProperty(type = "boolean", defaultValue = "true", allowedValues =
"true,false")
public static final String KOGITO_PERSISTENCE_DATA_INDEX_PROTO_GENERATION
= "kogito.persistence.data-index.proto.generation";
+ @KieInternal
public static final String
KOGITO_PERSISTENCE_DATA_INDEX_PROTO_GENERATION_DEFAULT = "true";
/**
* (boolean) enable/disable proto marshaller generation; default to true
*/
+ @KieProperty(type = "boolean", defaultValue = "true", allowedValues =
"true,false")
public static final String KOGITO_PERSISTENCE_PROTO_MARSHALLER =
"kogito.persistence.proto.marshaller";
+ @KieInternal
Review Comment:
same
##########
kogito-codegen-modules/kogito-codegen-processes/src/main/java/org/kie/kogito/codegen/process/persistence/PersistenceGenerator.java:
##########
@@ -85,16 +94,21 @@ public class PersistenceGenerator extends AbstractGenerator
{
/**
* (boolean) enable/disable proto generation for DATA-INDEX; default to
true
*/
+ @KieProperty(type = "boolean", defaultValue = "true", allowedValues =
"true,false")
public static final String KOGITO_PERSISTENCE_DATA_INDEX_PROTO_GENERATION
= "kogito.persistence.data-index.proto.generation";
+ @KieInternal
Review Comment:
same
##########
quarkus/extensions/kogito-quarkus-workflow-extension-common/kogito-quarkus-workflow-common-deployment/src/main/java/org/kie/kogito/quarkus/workflow/deployment/devservices/DataIndexInMemoryContainer.java:
##########
@@ -39,7 +40,9 @@ public class DataIndexInMemoryContainer extends
GenericContainer<DataIndexInMemo
/**
* This allows other applications to discover the running service and use
it instead of starting a new instance.
*/
+ @KieInternal
public static final String DEV_SERVICE_LABEL =
"kogito-dev-service-data-index";
+ @KieInternal
public static final String LATEST = "latest";
Review Comment:
same
##########
kogito-codegen-modules/kogito-codegen-api/src/main/java/org/kie/kogito/codegen/api/utils/KogitoCodeGenConstants.java:
##########
@@ -18,18 +18,26 @@
*/
package org.kie.kogito.codegen.api.utils;
+import org.kie.api.annotations.KieInternal;
+import org.kie.api.annotations.KieProperty;
+
public class KogitoCodeGenConstants {
private KogitoCodeGenConstants() {
}
+ @KieInternal
public static final String VALIDATION_CLASS =
"jakarta.validation.constraints.NotNull";
+ @KieInternal
Review Comment:
not property
##########
kogito-codegen-modules/kogito-codegen-api/src/main/java/org/kie/kogito/codegen/api/utils/KogitoCodeGenConstants.java:
##########
@@ -18,18 +18,26 @@
*/
package org.kie.kogito.codegen.api.utils;
+import org.kie.api.annotations.KieInternal;
+import org.kie.api.annotations.KieProperty;
+
public class KogitoCodeGenConstants {
private KogitoCodeGenConstants() {
}
+ @KieInternal
public static final String VALIDATION_CLASS =
"jakarta.validation.constraints.NotNull";
+ @KieInternal
public static final String OPENAPI_SPEC_CLASS =
"org.eclipse.microprofile.openapi.annotations.media.Schema";
+ @KieInternal
public static final String QUARKUS_TRANSACTION_MANAGER_CLASS =
"io.quarkus.narayana.jta.QuarkusTransaction";
+ @KieInternal
public static final String SPRING_TRANSACTION_MANAGER_CLASS =
"org.springframework.transaction.PlatformTransactionManager";
Review Comment:
not property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
