gitgabrio commented on code in PR #4321:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4321#discussion_r3457906227
##########
kogito-codegen-modules/kogito-codegen-core/src/main/java/org/kie/kogito/codegen/core/utils/CodegenUtil.java:
##########
@@ -35,11 +36,13 @@ public final class CodegenUtil {
/**
* Flag used to configure transaction enabling. Default to
<code>true</code>
*/
+ @KieProperty(type = "boolean", defaultValue = "true", allowedValues =
"true,false")
Review Comment:
We discussed that with @pefernan .
My original idea was to have a two-step approach:
1. introduce the annotations and make a first usage of them, even if not
perfect
2. reiterate and fix them; in the "composed" properties
AFAIK, the "composition" happen in tow ways:
`String A_COMPOSED_PROPERTY = BASE_PROEPRTY + "_something_else";`
`
return String.format("_something.%s.%s", generator.name(), propertyName);
`
My idea was to remove the composition (currently, those compositions makes
the code slightly harder to read), but this would lead to some duplication and
code-refactoring.
That is why I would prefer to tackle it on a second phase.
Does this make sense ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
