pan3793 commented on a change in pull request #1391:
URL: https://github.com/apache/incubator-kyuubi/pull/1391#discussion_r749357621
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/GetColumns.scala
##########
@@ -50,10 +50,18 @@ class GetColumns(
.add(TABLE_NAME, "string", nullable = true, "Table name")
.add(COLUMN_NAME, "string", nullable = true, "Column name")
.add(DATA_TYPE, "int", nullable = true, "SQL type from java.sql.Types")
- .add(TYPE_NAME, "string", nullable = true, "Data source dependent type
name, for a UDT" +
- " the type name is fully qualified")
- .add(COLUMN_SIZE, "int", nullable = true, "Column size. For char or date
types this is" +
- " the maximum number of characters, for numeric or decimal types this
is precision.")
+ .add(
+ TYPE_NAME,
+ "string",
+ nullable = true,
+ "Data source dependent type name, for a UDT" +
+ " the type name is fully qualified")
Review comment:
Seems not good.
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/GetColumns.scala
##########
@@ -50,10 +50,18 @@ class GetColumns(
.add(TABLE_NAME, "string", nullable = true, "Table name")
.add(COLUMN_NAME, "string", nullable = true, "Column name")
.add(DATA_TYPE, "int", nullable = true, "SQL type from java.sql.Types")
- .add(TYPE_NAME, "string", nullable = true, "Data source dependent type
name, for a UDT" +
- " the type name is fully qualified")
- .add(COLUMN_SIZE, "int", nullable = true, "Column size. For char or date
types this is" +
- " the maximum number of characters, for numeric or decimal types this
is precision.")
+ .add(
+ TYPE_NAME,
+ "string",
+ nullable = true,
+ "Data source dependent type name, for a UDT" +
+ " the type name is fully qualified")
+ .add(
+ COLUMN_SIZE,
+ "int",
+ nullable = true,
+ "Column size. For char or date types this is" +
+ " the maximum number of characters, for numeric or decimal types
this is precision.")
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
