[GitHub] [incubator-kyuubi] zhouyifan279 commented on pull request #1391: [KYUUBI #1383] Leverage Scalafmt to auto format scala code

Tue, 16 Nov 2021 00:08:41 -0800 


zhouyifan279 commented on pull request #1391:
URL: https://github.com/apache/incubator-kyuubi/pull/1391#issuecomment-969989870


   After traverse all the files changed by `scalafmt`, I find that rules in 
`.scalafmt.conf` are consistent with our current coding taste except the 
following scenarios:
   
   1. Intended indent
   
![image](https://user-images.githubusercontent.com/88070094/141943406-a7df7b40-ccbd-4da5-8c96-56751151955c.png)
   
   2. Multiple slashes
   
![image](https://user-images.githubusercontent.com/88070094/141943906-3b91db57-58f4-4cf7-a3fd-b5989aa03f17.png)
   
   3. Enum type declaration
   
![image](https://user-images.githubusercontent.com/88070094/141944294-262ec58b-899d-432d-aa54-5823c084d732.png)
   
   4. Method invocation with multiline params
   
![image](https://user-images.githubusercontent.com/88070094/141944761-c4d6a350-7075-419f-b74c-ac89522d7855.png)
   
   5. Multiline Seq/Array initialize
   
![image](https://user-images.githubusercontent.com/88070094/141945749-43139c6e-6eaf-4e5e-bb36-baf2b1e4f443.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to