pan3793 commented on a change in pull request #1391:
URL: https://github.com/apache/incubator-kyuubi/pull/1391#discussion_r749358676
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/GetTypeInfo.scala
##########
@@ -58,28 +78,29 @@ class GetTypeInfo(spark: SparkSession, session: Session)
private def isNumericType(javaType: Int): Boolean = {
javaType == TINYINT || javaType == SMALLINT || javaType == INTEGER ||
javaType == BIGINT ||
- javaType == FLOAT || javaType == FLOAT || javaType == DOUBLE || javaType
== DECIMAL
+ javaType == FLOAT || javaType == FLOAT || javaType == DOUBLE || javaType
== DECIMAL
}
private def toRow(name: String, javaType: Int, precision: Integer = null):
Row = {
- Row(name, // TYPE_NAME
- javaType, // DATA_TYPE
- precision, // PRECISION
- null, // LITERAL_PREFIX
- null, // LITERAL_SUFFIX
- null, // CREATE_PARAMS
- 1.toShort, // NULLABLE
- javaType == VARCHAR, // CASE_SENSITIVE
+ Row(
+ name, // TYPE_NAME
+ javaType, // DATA_TYPE
+ precision, // PRECISION
+ null, // LITERAL_PREFIX
+ null, // LITERAL_SUFFIX
+ null, // CREATE_PARAMS
+ 1.toShort, // NULLABLE
+ javaType == VARCHAR, // CASE_SENSITIVE
if (javaType < 1111) 3.toShort else 0.toShort, // SEARCHABLE
- !isNumericType(javaType), // UNSIGNED_ATTRIBUTE
- false, // FIXED_PREC_SCALE
- false, // AUTO_INCREMENT
- null, // LOCAL_TYPE_NAME
- 0.toShort, // MINIMUM_SCALE
- 0.toShort, // MAXIMUM_SCALE
- null, // SQL_DATA_TYPE
- null, // SQL_DATETIME_SUB
- if (isNumericType(javaType)) 10 else null // NUM_PREC_RADIX
+ !isNumericType(javaType), // UNSIGNED_ATTRIBUTE
+ false, // FIXED_PREC_SCALE
+ false, // AUTO_INCREMENT
+ null, // LOCAL_TYPE_NAME
+ 0.toShort, // MINIMUM_SCALE
+ 0.toShort, // MAXIMUM_SCALE
+ null, // SQL_DATA_TYPE
+ null, // SQL_DATETIME_SUB
+ if (isNumericType(javaType)) 10 else null // NUM_PREC_RADIX
Review comment:
let's disable the rule here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
