DickJC123 commented on a change in pull request #20635:
URL: https://github.com/apache/incubator-mxnet/pull/20635#discussion_r744059733
##########
File path: include/mxnet/storage.h
##########
@@ -71,18 +71,18 @@ class Storage {
* \param ctx Context information about the device and ID.
* \return Handle struct.
*/
- Handle Alloc(size_t size, Context ctx) {
+ Handle Alloc(size_t size, Context ctx, bool failsafe = false) {
Review comment:
Where you've add the failsafe parameter (here and elsewhere), please add
documentation. I suggest:
\* \param failsafe Return a handle with a null dptr if out of memory,
rather than exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
