mk-61 commented on pull request #20635: URL: https://github.com/apache/incubator-mxnet/pull/20635#issuecomment-962546584
> The number of environment variables seems a bit excessive to me (although I like that a lot more than precompiler statements). Is there no neater way? I can't imagine most people playing around with a dozen environment variables just to get the desired result. Also, this basically makes the code untestable due to the sheer number of combinations. It is expected that in vast majority of cases users can just leave all the new environment variables alone - defaults have been chosen with care. However, in some corner cases it can be useful to have a bit more control, so I was weary of just hard-coding the defaults. Please note that not all these variables are new - in some cases I was using already existing ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
