DickJC123 commented on pull request #20635: URL: https://github.com/apache/incubator-mxnet/pull/20635#issuecomment-963747883
> The number of environment variables seems a bit excessive to me (although I like that a lot more than precompiler statements). Is there no neater way? I can't imagine most people playing around with a dozen environment variables just to get the desired result. Also, this basically makes the code untestable due to the sheer number of combinations. I'm not so worried about the combinations of the new env vars, since most are controlling independent filters on the list of potential convolution configs. We could however think about dividing the env var descriptions into "basic" and "advanced" usage sections, so that new users don't feel overwhelmed when reviewing the list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
