bgawrych commented on a change in pull request #20741:
URL: https://github.com/apache/incubator-mxnet/pull/20741#discussion_r753176557
##########
File path: src/operator/contrib/adaptive_avg_pooling.cc
##########
@@ -24,6 +24,9 @@
#include "adaptive_avg_pooling-inl.h"
// #include "elemwise_op_common.h"
Review comment:
This comment can be removed
##########
File path: src/operator/nn/pooling.cc
##########
@@ -290,7 +290,7 @@ void PoolingComputeExCPU(const nnvm::NodeAttrs& attrs,
workspace = &outputs[1];
}
DNNL_OPCHECK_INIT(false, 1, inputs, outputs);
- DNNLPoolingCompute(ctx, param, inputs[0], req[0], outputs[0], workspace);
+ DNNLPoolingCompute(ctx, param, inputs[0], req[0], outputs[0], workspace,
false);
Review comment:
I wonder if we can run it like all others ops.
DNNL_OPCHECK_INIT...
DNNLRun(DNNLPoolingCompute...
DNNL_OPCHECK_RUN...
This one additional bool parameter can be passed by template argument and
IsView check in checking support function won't be necessary. What do you
think? + @bartekkuncer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
