bartekkuncer commented on a change in pull request #20741:
URL: https://github.com/apache/incubator-mxnet/pull/20741#discussion_r755112362
##########
File path: src/operator/nn/pooling.cc
##########
@@ -290,7 +290,7 @@ void PoolingComputeExCPU(const nnvm::NodeAttrs& attrs,
workspace = &outputs[1];
}
DNNL_OPCHECK_INIT(false, 1, inputs, outputs);
- DNNLPoolingCompute(ctx, param, inputs[0], req[0], outputs[0], workspace);
+ DNNLPoolingCompute(ctx, param, inputs[0], req[0], outputs[0], workspace,
false);
Review comment:
Making it consistent with other operators is desirable.
@piotrwolinski-intel Please check if it introduces any problems.
Template here might make the code more readable as well, especially with
`true/false` boolean parameter changed to simple `enum class PoolingType {
regular, adaptive };`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
