bartekkuncer commented on a change in pull request #20741:
URL: https://github.com/apache/incubator-mxnet/pull/20741#discussion_r755195486
##########
File path: src/operator/nn/pooling.cc
##########
@@ -290,7 +290,7 @@ void PoolingComputeExCPU(const nnvm::NodeAttrs& attrs,
workspace = &outputs[1];
}
DNNL_OPCHECK_INIT(false, 1, inputs, outputs);
- DNNLPoolingCompute(ctx, param, inputs[0], req[0], outputs[0], workspace);
+ DNNLPoolingCompute(ctx, param, inputs[0], req[0], outputs[0], workspace,
false);
Review comment:
In my opinion as @piotrwolinski-intel is working currently on backward
implementation for this op, this PR could be merged as is and the changes we
are talking about can be applied along with backward propagation addition. Do
you agree @bgawrych ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
