bartekkuncer commented on code in PR #20997: URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r847234251
########## src/operator/nn/dnnl/dnnl_sum.cc: ########## @@ -23,10 +23,11 @@ * \author Da Zheng */ #include <iostream> +#include <vector> #include "operator/operator_common.h" #include "dnnl_base-inl.h" -#include "dnnl_ops-inl.h" +#include "dnnl_sum-inl.h" Review Comment: Please uniform sum operator - class declaration (and its functions) should be in inl.h file. Please see how it is done in e.g. dnnl_eltwise* files. ########## src/operator/quantization/dnnl/dnnl_quantized_act.cc: ########## @@ -23,8 +23,8 @@ */ #if MXNET_USE_ONEDNN == 1 -#include "operator/nn/dnnl/dnnl_ops-inl.h" #include "operator/quantization/quantization_utils.h" +#include "operator/nn/activation-inl.h" Review Comment: Unalphabetical order. ########## src/operator/tensor/elemwise_unary_op_basic.cc: ########## @@ -23,8 +23,8 @@ */ #include <mxnet/base.h> -#include "../nn/dnnl/dnnl_ops-inl.h" #include "./elemwise_binary_op-inl.h" +#include "../nn/dnnl/dnnl_copy-inl.h" Review Comment: Maybe remove the dots form the includes? ########## src/operator/tensor/matrix_op.cc: ########## @@ -26,11 +26,11 @@ #include "./elemwise_unary_op.h" #if MXNET_USE_ONEDNN == 1 #include "../nn/dnnl/dnnl_base-inl.h" -#include "../nn/dnnl/dnnl_ops-inl.h" #include "../nn/dnnl/dnnl_reshape-inl.h" #include "../nn/dnnl/dnnl_slice-inl.h" #include "../nn/dnnl/dnnl_transpose-inl.h" #include "../nn/dnnl/dnnl_split-inl.h" +#include "../nn/dnnl/dnnl_stack-inl.h" Review Comment: Maybe remove dots form the includes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
