bgawrych commented on code in PR #20997: URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r855847913
########## src/operator/leaky_relu-inl.h: ########## @@ -479,6 +479,18 @@ void LeakyReLUGradCompute(const nnvm::NodeAttrs& attrs, }); } +void DNNLLeakyReluForward(const nnvm::NodeAttrs& attrs, + const OpContext& ctx, + const NDArray& in_data, + const OpReqType& req, + const NDArray& out_data); + +void DNNLLeakyReluBackward(const nnvm::NodeAttrs& attrs, + const OpContext& ctx, + const std::vector<NDArray>& inputs, + const std::vector<OpReqType>& req, + const std::vector<NDArray>& outputs); + Review Comment: I think it would be better to move these declaration to one of dnnl file - e.g. dnnl_activation-inl.h and then included in this file with #if MXNET_USE_ONEDNN == 1 guard This applies to all other changes in this PR as well btw. current declaration should be also guarded with #if MXNET_USE_ONEDNN == 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
