bartekkuncer commented on code in PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r855877549
##########
src/operator/nn/dnnl/dnnl_reshape-inl.h:
##########
@@ -53,6 +53,13 @@ typedef OpSignature DNNLReshapeSignature;
DNNLReshapeFwd& GetReshapeForward(const OpReqType& req,
const NDArray& input,
const NDArray& output);
+
+void DNNLReshapeForward(const nnvm::NodeAttrs& attrs,
Review Comment:
All other operators should be done like this one.
##########
src/operator/leaky_relu.cc:
##########
@@ -27,7 +27,6 @@
#include "../common/alm.h"
#if MXNET_USE_ONEDNN == 1
#include "./nn/dnnl/dnnl_base-inl.h"
-#include "./nn/dnnl/dnnl_ops-inl.h"
Review Comment:
Continuation of @bgawrych's comment -> here #include
"./nn/dnnl/dnnl_ops-inl.h" should be replaced with an include of other
dnnl_XXX-inl.h file with the declarations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
